Fix author list comma behavior #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the authors list in the publications element did not add commas as expected in some cases.
I believe the issue came from referencing the incorrect variable when iterating through the author list:
hugo-astatine-theme/layouts/partials/publication.html
Line 19 in 17f1644
Since
.in this scope refers toauthorelements, which have anameand optionallymevalues, it can only have a length of either 1 or 2. Instead,.should be replaced with a reference to the entire list of authors.The pull request fixes the issue by creating a new variable
$authorlist, which may have been what the conditional intended to reference.